Mercurial > projects > ldc
view gen/cl_helpers.cpp @ 1499:df11cdec45a2
Another shot at fixing the issues with (constant) struct literals and their addresses. See DMD2682, #218, #324.
The idea is to separate the notion of const from 'this variable can always be
replaced with its initializer' in the frontend. To do that, I introduced
Declaration::isSameAsInitializer, which is overridden in VarDeclaration to
return false for constants that have a struct literal initializer.
So
{{{
const S s = S(5);
void foo() { auto ps = &s; }
// is no longer replaced by
void foo() { auto ps = &(S(5)); }
}}}
To make taking the address of a struct constant with a struct-initializer
outside of function scope possible, I made sure that AddrExp::optimize doesn't
try to run the argument's optimization with WANTinterpret - that'd again
replace the constant with a struct literal temporary.
author | Christian Kamm <kamm incasoftware de> |
---|---|
date | Sun, 14 Jun 2009 19:49:58 +0200 |
parents | b30fe7e1dbb9 |
children | 40bd4a0d4870 |
line wrap: on
line source
#include "gen/cl_helpers.h" #include "root.h" #include "rmem.h" #include <cctype> // isupper, tolower #include <algorithm> #include <utility> #include <stdarg.h> namespace opts { // Helper function static char toLower(char c) { if (isupper(c)) return tolower(c); return c; } bool FlagParser::parse(cl::Option &O, const char *ArgName, const std::string &Arg, bool &Val) { // Make a std::string out of it to make comparisons easier // (and avoid repeated conversion) std::string argname = ArgName; typedef std::vector<std::pair<std::string, bool> >::iterator It; for (It I = switches.begin(), E = switches.end(); I != E; ++I) { std::string name = I->first; if (name == argname || (name.length() < argname.length() && argname.substr(0, name.length()) == name && argname[name.length()] == '=')) { if (!cl::parser<bool>::parse(O, ArgName, Arg, Val)) { Val = (Val == I->second); return false; } // Invalid option value break; } } return true; } void FlagParser::getExtraOptionNames(std::vector<const char*> &Names) { typedef std::vector<std::pair<std::string, bool> >::iterator It; for (It I = switches.begin() + 1, E = switches.end(); I != E; ++I) { Names.push_back(I->first.c_str()); } } MultiSetter::MultiSetter(bool invert, bool* p, ...) { this->invert = invert; if (p) { locations.push_back(p); va_list va; va_start(va, p); while (p = va_arg(va, bool*)) { locations.push_back(p); } } } void MultiSetter::operator=(bool val) { typedef std::vector<bool*>::iterator It; for (It I = locations.begin(), E = locations.end(); I != E; ++I) { **I = (val != invert); } } void ArrayAdapter::push_back(const char* cstr) { if (!cstr || !*cstr) error("Expected argument to '-%s'", name); if (!*arrp) *arrp = new Array; (*arrp)->push(mem.strdup(cstr)); } } // namespace opts