Mercurial > projects > ldc
diff gen/llvmhelpers.cpp @ 715:30b42a283c8e
Removed TypeOpaque from DMD.
Changed runtime functions taking opaque[] to void[].
Implemented proper type painting, to avoid "resizing" array casts in runtime calls that previously took opaque[].
Implemented dynamic arrays as first class types, this implements proper ABI for these types on x86.
Added dwarf region end after call to assert function, fixes some problems with llvm not allowing this to be missing.
Reverted change to WithStatement from rev [704] it breaks MiniD, mini/with2.d needs to be fixed some other way...
Fixed tango bug 1339 in runtime, problem with _adReverseChar on invalid UTF-8.
Disabled .bc generation in the compiler runtime part, genobj.d triggers some llvm bug when using debug info. the .o seems to work fine.
author | Tomas Lindquist Olsen <tomas.l.olsen@gmail.com> |
---|---|
date | Wed, 22 Oct 2008 14:55:33 +0200 |
parents | b972fb129d37 |
children | 7261ff0f95ff |
line wrap: on
line diff
--- a/gen/llvmhelpers.cpp Wed Oct 22 13:48:54 2008 +0200 +++ b/gen/llvmhelpers.cpp Wed Oct 22 14:55:33 2008 +0200 @@ -117,35 +117,14 @@ const char* fname = msg ? "_d_assert_msg" : "_d_assert"; llvm::Function* fn = LLVM_D_GetRuntimeFunction(gIR->module, fname); - // param attrs - llvm::AttrListPtr palist; - int idx = 1; - // msg param if (msg) { - if (DSliceValue* s = msg->isSlice()) - { - llvm::AllocaInst* alloc = gIR->func()->msgArg; - if (!alloc) - { - alloc = DtoAlloca(DtoArrayType(LLType::Int8Ty), ".assertmsg"); - DtoSetArray(alloc, DtoArrayLen(s), DtoArrayPtr(s)); - gIR->func()->msgArg = alloc; - } - args.push_back(alloc); - } - else - { - args.push_back(msg->getRVal()); - } - palist = palist.addAttr(idx++, llvm::Attribute::ByVal); + args.push_back(msg->getRVal()); } // file param - args.push_back(gIR->dmodule->ir.irModule->fileName); - palist = palist.addAttr(idx++, llvm::Attribute::ByVal); - + args.push_back(DtoLoad(gIR->dmodule->ir.irModule->fileName)); // line param LLConstant* c = DtoConstUint(loc->linnum); @@ -153,7 +132,10 @@ // call CallOrInvoke* call = gIR->CreateCallOrInvoke(fn, args.begin(), args.end()); - call->setAttributes(palist); + + // end debug info + if (global.params.symdebug) + DtoDwarfFuncEnd(gIR->func()->decl); // after assert is always unreachable gIR->ir->CreateUnreachable(); @@ -445,8 +427,12 @@ DtoSetArrayToNull(lhs->getLVal()); } // reference assignment + else if (t2->ty == Tarray) { + DtoStore(rhs->getRVal(), lhs->getLVal()); + } + // some implicitly converting ref assignment else { - DtoArrayAssign(lhs->getLVal(), rhs->getRVal()); + DtoSetArray(lhs->getLVal(), DtoArrayLen(rhs), DtoArrayPtr(rhs)); } } else if (t->ty == Tsarray) { @@ -756,6 +742,52 @@ } } +////////////////////////////////////////////////////////////////////////////////////////// + +DValue* DtoPaintType(Loc& loc, DValue* val, Type* to) +{ + Type* from = val->getType()->toBasetype(); + Logger::println("repainting from '%s' to '%s'", from->toChars(), to->toChars()); + + if (from->ty == Tarray) + { + Type* at = to->toBasetype(); + assert(at->ty == Tarray); + Type* elem = at->next->pointerTo(); + if (DSliceValue* slice = val->isSlice()) + { + return new DSliceValue(to, slice->len, DtoBitCast(slice->ptr, DtoType(elem))); + } + else if (val->isLVal()) + { + LLValue* ptr = val->getLVal(); + ptr = DtoBitCast(ptr, DtoType(at->pointerTo())); + return new DVarValue(to, ptr); + } + else + { + LLValue *len, *ptr; + len = DtoArrayLen(val); + ptr = DtoArrayPtr(val); + ptr = DtoBitCast(ptr, DtoType(elem)); + return new DImValue(to, DtoAggrPair(len, ptr, "tmp")); + } + } + else if (from->ty == Tpointer || from->ty == Tclass || from->ty == Taarray) + { + Type* b = to->toBasetype(); + assert(b->ty == Tpointer || b->ty == Tclass || b->ty == Taarray); + LLValue* ptr = DtoBitCast(val->getRVal(), DtoType(b)); + return new DImValue(to, ptr); + } + else + { + assert(!val->isLVal()); + assert(DtoType(to) == DtoType(to)); + return new DImValue(to, val->getRVal()); + } +} + /****************************************************************************************/ /*//////////////////////////////////////////////////////////////////////////////////////// // TEMPLATE HELPERS @@ -1413,7 +1445,7 @@ static LLConstant* expand_to_sarray(Type *base, Expression* exp) { - Logger::println("building type %s from expression (%s) of type %s", base->toChars(), exp->toChars(), exp->type->toChars()); + Logger::println("building type %s to expression (%s) of type %s", base->toChars(), exp->toChars(), exp->type->toChars()); const LLType* dstTy = DtoType(base); if (Logger::enabled()) Logger::cout() << "final llvm type requested: " << *dstTy << '\n'; @@ -1463,12 +1495,12 @@ { if (base->ty == Tsarray) { - Logger::println("type is a static array, building constant array initializer from single value"); + Logger::println("type is a static array, building constant array initializer to single value"); return expand_to_sarray(base, exp); } else { - error("cannot yet convert default initializer %s from type %s to %s", exp->toChars(), exp->type->toChars(), type->toChars()); + error("cannot yet convert default initializer %s to type %s to %s", exp->toChars(), exp->type->toChars(), type->toChars()); fatal(); } assert(0);