comparison dmd/expression.h @ 1499:df11cdec45a2

Another shot at fixing the issues with (constant) struct literals and their addresses. See DMD2682, #218, #324. The idea is to separate the notion of const from 'this variable can always be replaced with its initializer' in the frontend. To do that, I introduced Declaration::isSameAsInitializer, which is overridden in VarDeclaration to return false for constants that have a struct literal initializer. So {{{ const S s = S(5); void foo() { auto ps = &s; } // is no longer replaced by void foo() { auto ps = &(S(5)); } }}} To make taking the address of a struct constant with a struct-initializer outside of function scope possible, I made sure that AddrExp::optimize doesn't try to run the argument's optimization with WANTinterpret - that'd again replace the constant with a struct literal temporary.
author Christian Kamm <kamm incasoftware de>
date Sun, 14 Jun 2009 19:49:58 +0200
parents 229e02867307
children def7a1d494fd
comparison
equal deleted inserted replaced
1498:899a928ac905 1499:df11cdec45a2
507 void toCBuffer(OutBuffer *buf, HdrGenState *hgs); 507 void toCBuffer(OutBuffer *buf, HdrGenState *hgs);
508 void toMangleBuffer(OutBuffer *buf); 508 void toMangleBuffer(OutBuffer *buf);
509 void scanForNestedRef(Scope *sc); 509 void scanForNestedRef(Scope *sc);
510 Expression *optimize(int result); 510 Expression *optimize(int result);
511 Expression *interpret(InterState *istate); 511 Expression *interpret(InterState *istate);
512 // LDC: struct literals aren't lvalues! Taking their address can lead to 512 Expression *toLvalue(Scope *sc, Expression *e);
513 // incorrect behavior, see LDC#218, DMD#2682
514 // Expression *toLvalue(Scope *sc, Expression *e);
515 513
516 int inlineCost(InlineCostState *ics); 514 int inlineCost(InlineCostState *ics);
517 Expression *doInline(InlineDoState *ids); 515 Expression *doInline(InlineDoState *ids);
518 Expression *inlineScan(InlineScanState *iss); 516 Expression *inlineScan(InlineScanState *iss);
519 517