annotate gen/warnings.cpp @ 1605:1d5721f9ae18

[WIP] Merge DMD r251: bugzilla 111 (appending a dchar to a char[]) This patch needs some work in the code generation, because of the runtime changes (functions "_d_arrayappendcd" and "_d_arrayappendwd" are added). This doesn't affect existing code though, it just makes with patch a little useless, because something like this: char [] s; s ~= '\u6211'; That failed to compile with a nice error message previously to this change, now fails with and ugly error message (a failed assertion). Apparently there is a regression introduced by this patch too, when compiling Dil I get this assertion message: ldc: /home/luca/tesis/ldc/gen/statements.cpp:132: virtual void ReturnStatement::toIR(IRState*): Assertion `p->topfunc()->getReturnType() == llvm::Type::getVoidTy(gIR->context())' failed. 0 ldc 0x08a91628 Thank god we have bisecting capabilities in VCSs now ;) --- dmd/expression.c | 47 +++++++++++++++++++++++++++++++++++++++++------ 1 files changed, 41 insertions(+), 6 deletions(-)
author Leandro Lucarella <llucax@gmail.com>
date Wed, 06 Jan 2010 15:18:19 -0300
parents a591aa6bd6dc
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
1568
a591aa6bd6dc Forgot to add files.
Tomas Lindquist Olsen <tomas.l.olsen gmail com>
parents:
diff changeset
1 #include "mars.h"
a591aa6bd6dc Forgot to add files.
Tomas Lindquist Olsen <tomas.l.olsen gmail com>
parents:
diff changeset
2 #include "mtype.h"
a591aa6bd6dc Forgot to add files.
Tomas Lindquist Olsen <tomas.l.olsen gmail com>
parents:
diff changeset
3 #include "expression.h"
a591aa6bd6dc Forgot to add files.
Tomas Lindquist Olsen <tomas.l.olsen gmail com>
parents:
diff changeset
4
a591aa6bd6dc Forgot to add files.
Tomas Lindquist Olsen <tomas.l.olsen gmail com>
parents:
diff changeset
5 #include "gen/warnings.h"
a591aa6bd6dc Forgot to add files.
Tomas Lindquist Olsen <tomas.l.olsen gmail com>
parents:
diff changeset
6
a591aa6bd6dc Forgot to add files.
Tomas Lindquist Olsen <tomas.l.olsen gmail com>
parents:
diff changeset
7 void warnInvalidPrintfCall(Loc loc, Expression* arguments, size_t nargs)
a591aa6bd6dc Forgot to add files.
Tomas Lindquist Olsen <tomas.l.olsen gmail com>
parents:
diff changeset
8 {
a591aa6bd6dc Forgot to add files.
Tomas Lindquist Olsen <tomas.l.olsen gmail com>
parents:
diff changeset
9 Expression* arg = arguments;
a591aa6bd6dc Forgot to add files.
Tomas Lindquist Olsen <tomas.l.olsen gmail com>
parents:
diff changeset
10
a591aa6bd6dc Forgot to add files.
Tomas Lindquist Olsen <tomas.l.olsen gmail com>
parents:
diff changeset
11 // make sure first argument is a string literal, or we can't do much
a591aa6bd6dc Forgot to add files.
Tomas Lindquist Olsen <tomas.l.olsen gmail com>
parents:
diff changeset
12 // TODO make it smarter ?
a591aa6bd6dc Forgot to add files.
Tomas Lindquist Olsen <tomas.l.olsen gmail com>
parents:
diff changeset
13 if (arg->op != TOKstring)
a591aa6bd6dc Forgot to add files.
Tomas Lindquist Olsen <tomas.l.olsen gmail com>
parents:
diff changeset
14 return; // assume valid
a591aa6bd6dc Forgot to add files.
Tomas Lindquist Olsen <tomas.l.olsen gmail com>
parents:
diff changeset
15
a591aa6bd6dc Forgot to add files.
Tomas Lindquist Olsen <tomas.l.olsen gmail com>
parents:
diff changeset
16 StringExp* strexp = (StringExp*)arg;
a591aa6bd6dc Forgot to add files.
Tomas Lindquist Olsen <tomas.l.olsen gmail com>
parents:
diff changeset
17
a591aa6bd6dc Forgot to add files.
Tomas Lindquist Olsen <tomas.l.olsen gmail com>
parents:
diff changeset
18 // not wchar or dhar
a591aa6bd6dc Forgot to add files.
Tomas Lindquist Olsen <tomas.l.olsen gmail com>
parents:
diff changeset
19 if (strexp->sz != 1)
a591aa6bd6dc Forgot to add files.
Tomas Lindquist Olsen <tomas.l.olsen gmail com>
parents:
diff changeset
20 {
a591aa6bd6dc Forgot to add files.
Tomas Lindquist Olsen <tomas.l.olsen gmail com>
parents:
diff changeset
21 warning(loc, "printf does not support wchar and dchar strings");
a591aa6bd6dc Forgot to add files.
Tomas Lindquist Olsen <tomas.l.olsen gmail com>
parents:
diff changeset
22 return;
a591aa6bd6dc Forgot to add files.
Tomas Lindquist Olsen <tomas.l.olsen gmail com>
parents:
diff changeset
23 }
a591aa6bd6dc Forgot to add files.
Tomas Lindquist Olsen <tomas.l.olsen gmail com>
parents:
diff changeset
24
a591aa6bd6dc Forgot to add files.
Tomas Lindquist Olsen <tomas.l.olsen gmail com>
parents:
diff changeset
25 #if 0
a591aa6bd6dc Forgot to add files.
Tomas Lindquist Olsen <tomas.l.olsen gmail com>
parents:
diff changeset
26 // check the format string
a591aa6bd6dc Forgot to add files.
Tomas Lindquist Olsen <tomas.l.olsen gmail com>
parents:
diff changeset
27 const char* str = (char*)strexp->string;
a591aa6bd6dc Forgot to add files.
Tomas Lindquist Olsen <tomas.l.olsen gmail com>
parents:
diff changeset
28 for (size_t i = 0; i < strexp->len; ++i)
a591aa6bd6dc Forgot to add files.
Tomas Lindquist Olsen <tomas.l.olsen gmail com>
parents:
diff changeset
29 {
a591aa6bd6dc Forgot to add files.
Tomas Lindquist Olsen <tomas.l.olsen gmail com>
parents:
diff changeset
30 // TODO
a591aa6bd6dc Forgot to add files.
Tomas Lindquist Olsen <tomas.l.olsen gmail com>
parents:
diff changeset
31 }
a591aa6bd6dc Forgot to add files.
Tomas Lindquist Olsen <tomas.l.olsen gmail com>
parents:
diff changeset
32 #endif
a591aa6bd6dc Forgot to add files.
Tomas Lindquist Olsen <tomas.l.olsen gmail com>
parents:
diff changeset
33 }