# HG changeset patch
# User Aziz K?ksal <aziz.koeksal@gmail.com>
# Date 1191792135 -7200
# Node ID cac9c8d637adaf4681b1ea10c53d86f5003218b0
# Parent  063cd016c913c521c5b6e5caf955aa182b6ec365
Fix: members related to error info weren't updated correctly.

diff -r 063cd016c913 -r cac9c8d637ad trunk/src/dil/Information.d
--- a/trunk/src/dil/Information.d	Thu Oct 04 22:31:59 2007 +0200
+++ b/trunk/src/dil/Information.d	Sun Oct 07 23:22:15 2007 +0200
@@ -87,6 +87,7 @@
 
   void set(size_t lineNum, char* lineBegin, char* to)
   {
+    assert(lineBegin !is null && to !is null);
     assert(lineBegin <= to);
     this.lineNum   = lineNum;
     this.lineBegin = lineBegin;
diff -r 063cd016c913 -r cac9c8d637ad trunk/src/dil/Lexer.d
--- a/trunk/src/dil/Lexer.d	Thu Oct 04 22:31:59 2007 +0200
+++ b/trunk/src/dil/Lexer.d	Sun Oct 07 23:22:15 2007 +0200
@@ -39,11 +39,10 @@
   char* p; /// Points to the current character in the source text.
   char* end; /// Points one character past the end of the source text.
 
-  // Members used to generate error messages:
+  // Members used for error messages:
   Information[] errors;
   char* lineBegin; /// Always points to the beginning of the current line.
   uint loc = 1; /// Actual line of code.
-  uint loc_old; /// Store actual line number when #line token is scanned.
   uint loc_hline; /// Line number set by #line.
   uint inTokenString; /// > 0 if inside q{ }
   Location errorLoc;
@@ -180,11 +179,15 @@
     this.lineBegin = p;
   }
 
-  private void scanNext(ref Token* t)
+  private void scanNext(bool rescan)(ref Token* t)
   {
     assert(t !is null);
     if (t.next)
+    {
       t = t.next;
+      static if (rescan == true)
+        rescanNewlines(*t);
+    }
     else if (t != this.tail)
     {
       Token* new_t = new Token;
@@ -197,15 +200,130 @@
 
   void peek(ref Token* t)
   {
-    scanNext(t);
+    scanNext!(false)(t);
   }
 
   TOK nextToken()
   {
-    scanNext(this.token);
+    scanNext!(true)(this.token);
     return this.token.type;
   }
 
+  void rescanNewlines(ref Token t)
+  {
+    auto p = t.ws;
+    auto end = t.start;
+
+    if (p !is null)
+    {
+      assert(end !is null);
+      // Scan preceding whitespace for newlines.
+      do
+      {
+        switch (*p)
+        {
+        case '\r':
+          if (p[1] == '\n')
+            ++p;
+        case '\n':
+          ++loc;
+          setLineBegin(p + 1);
+          break;
+        case LS[0]:
+          assert(p+2 < end && p[1] == LS[1] && (p[2] == LS[2] || p[2] == PS[2]));
+          ++p; ++p;
+          ++loc;
+          setLineBegin(p + 1);
+          break;
+        default:
+          assert(isspace(*p));
+        }
+        ++p;
+      } while (p < end)
+    }
+
+    if (t.type == TOK.String && t.start[0] != '\\' ||
+        t.type == TOK.Comment && t.start[1] != '/')
+    {
+      // String literals and comments are the only tokens that can have
+      // newlines.
+      p = t.start;
+      end = t.end;
+      assert(p !is null && end !is null);
+      do
+      {
+        switch (*p)
+        {
+        case '\r':
+          if (p[1] == '\n')
+            ++p;
+        case '\n':
+          ++loc;
+          setLineBegin(p + 1);
+          break;
+        case LS[0]:
+          if (p[1] == LS[1] && (p[2] == LS[2] || p[2] == PS[2]))
+          {
+            ++p; ++p;
+            ++loc;
+            setLineBegin(p + 1);
+            break;
+          }
+        default:
+        }
+        ++p;
+      } while (p < end)
+    }
+    else
+    {
+      if (t.type == TOK.HashLine)
+        evaluateHashLine(t);
+
+      assert(delegate() {
+          p = t.start;
+          end = t.end;
+          while (p < end)
+          {
+            if (*p == '\n' || *p == '\r' ||
+                (p+2) < end && *p == LS[0] && p[1] == LS[1] && (p[2] == LS[2] || p[2] == PS[2]))
+              return false;
+            ++p;
+          }
+          return true;
+        }() == true, "Token '" ~ t.srcText ~ "' has unexpected newline."
+      );
+    }
+  }
+
+  struct LocState
+  {
+    char[] filePath;
+    uint loc;
+    uint loc_hline;
+    char* lineBegin;
+  }
+
+  LocState getState()
+  {
+    LocState s;
+    s.filePath = this.errorLoc.filePath;
+    s.lineBegin = this.lineBegin;
+    s.loc_hline = this.loc_hline;
+    s.loc = this.loc;
+    return s;
+  }
+
+  void restoreState(LocState s)
+  {
+    if (s.lineBegin == this.lineBegin)
+      return;
+    assert(s.loc != this.loc);
+    this.errorLoc.setFilePath(s.filePath);
+    this.lineBegin = s.lineBegin;
+    this.loc = s.loc;
+    this.loc_hline = s.loc_hline;
+  }
+
   public void scan_(out Token t)
   in
   {
@@ -1690,7 +1808,7 @@
     auto tokenLineBegin = lineBegin;
 
     // A guard against changes to particular members:
-    // this.loc_old, this.loc_hline and this.errorLoc.filePath
+    // this.loc_hline and this.errorLoc.filePath
     ++inTokenString;
 
     uint loc = this.loc;
@@ -2450,12 +2568,7 @@
 
     // Evaluate #line only when not in token string.
     if (!inTokenString)
-    {
-      this.loc_old = this.loc;
-      this.loc_hline = t.line_num.uint_ - 1;
-      if (t.line_filespec)
-        this.errorLoc.setFilePath(t.line_filespec.str);
-    }
+      evaluateHashLine(t);
     t.end = p;
 
     return;
@@ -2464,6 +2577,17 @@
     error(errorAtColumn, mid);
   }
 
+  void evaluateHashLine(ref Token t)
+  {
+    assert(t.type == TOK.HashLine);
+    if (t.line_num)
+    {
+      this.loc_hline = this.loc - t.line_num.uint_ + 1;
+      if (t.line_filespec)
+        this.errorLoc.setFilePath(t.line_filespec.str);
+    }
+  }
+
   /+
     Insert an empty dummy token before t.
     Useful in the parsing phase for representing a node in the AST
@@ -2499,8 +2623,7 @@
 
   uint errorLineNum(uint loc)
   {
-    // ∆loc + line_num_of(#line)
-    return loc - this.loc_old + this.loc_hline;
+    return loc - this.loc_hline;
   }
 
   void error(char* columnPos, MID mid, ...)
diff -r 063cd016c913 -r cac9c8d637ad trunk/src/dil/Parser.d
--- a/trunk/src/dil/Parser.d	Thu Oct 04 22:31:59 2007 +0200
+++ b/trunk/src/dil/Parser.d	Sun Oct 07 23:22:15 2007 +0200
@@ -96,6 +96,7 @@
     auto oldToken     = this.token;
     auto oldPrevToken = this.prevToken;
     auto oldCount     = this.errorCount;
+    auto lexerState   = this.lx.getState();
 
     auto result = parseMethod();
 
@@ -103,6 +104,7 @@
     if (errorCount != oldCount)
     {
       // Restore members.
+      lx.restoreState(lexerState);
       token      = oldToken;
       prevToken  = oldPrevToken;
       lx.token   = oldToken;
@@ -123,10 +125,23 @@
 
   TOK peekNext()
   {
+    auto state = lx.getState();
     Token* next = token;
     do
       lx.peek(next);
     while (next.isWhitespace) // Skip whitespace
+    lx.restoreState(state);
+    return next.type;
+  }
+
+  TOK peekAfter(ref Token* next)
+  {
+    assert(next !is null);
+    auto state = lx.getState();
+    do
+      lx.peek(next);
+    while (next.isWhitespace) // Skip whitespace
+    lx.restoreState(state);
     return next.type;
   }
 
@@ -271,11 +286,9 @@
     version(D2)
     {
       auto next = token;
-      lx.peek(next);
-      if (next.type == T.LParen)
+      if (peekAfter(next) == T.LParen)
       {
-        lx.peek(next);
-        if (next.type != T.RParen)
+        if (peekAfter(next) != T.RParen)
           goto case_Declaration;
       }
       else
@@ -3794,6 +3807,8 @@
     assert(token.type == T.LParen);
     Token* next = token;
     uint level = 1;
+    auto state = lx.getState();
+  Loop:
     while (1)
     {
       lx.peek(next);
@@ -3801,22 +3816,22 @@
       {
       case T.RParen:
         if (--level == 0)
-        { // Closing parentheses found.
-          lx.peek(next);
-          break;
+        { // Last, closing parentheses found.
+          do
+            lx.peek(next);
+          while (next.isWhitespace)
+          break Loop;
         }
-        continue;
+        break;
       case T.LParen:
         ++level;
-        continue;
+        break;
       case T.EOF:
-        break;
+        break Loop;
       default:
-        continue;
       }
-      break;
     }
-
+    lx.restoreState(state);
     return next.type == tok;
   }